DM-5252: Base "bright star" cut on S/N instead of magnitudes #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmwv
force-pushed
the
tickets/DM-5252
branch
2 times, most recently
from
009f080
to
88c7bc5
Compare
Use brightSnr instead of good_mag_limit in all associated files.
Note: The 'brightSnr' cut for calculating SRD metrics remains a much more strigent additional cut on the S/N suitable for restricting to bright sources for the purposes of calculating SRD metrics.
plotAstrometry and plotPhotometry have new function argument orders and lists to relfect on the quantities they actually use. Added a SNR vs. magnitude plot as part of plotPhotometry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use S/N threshold instead of mag threshold to define the "bright" stars to use for the SRD and related calculations.
Plot astrometric RMS vs. SNR and mag.