DM-4848: Measure photometric repeatability and correctness of reported errors #3
Conversation
|
|
||
| ``` | ||
| eups distrib obs_decam obs_cfht | ||
| eups distrib obs_decam obs_cfht validation_data_decam validation_data_cfht validate_drp |
There was a problem hiding this comment.
eups distrib install obs_decam ....
Adapt matching from the lsst/afw/examples/repeatability.ipynb tickets/DM-3896 Calculate astrometric scatter as median(RMS across all objects) instead of median(dist visit-ref of each measurement). Turns out not to really matter. Calculate aggregate quantities for each object using GroupView and some new functions written for this use and equivalents for GroupView.apply. Ref merged into visits lists as all quantities are now calculated with respect to the group mean values in read of a designated reference.
This calculations the median of the set of (RMS for each source). There are some more specific description of exactly what to calculate in the SRD that should be implemented later. Reduced matchRef requirement a bit to 5000.
Separate loadAndMatchData into loadAndMatchData + analyzeData Improve plotting. Clarify mag_RMS vs. delta_mag.
Include the code from afw/examples/repeatability tickets/DM-3896 to calculate quantities as specified by the SRD for photometric repeatability.
Previously was not generating safeMatches with a minimum brightness. Fixing this results in reasonable estimates for PA1 and PA2. Prefix plot filenames with name of repo.
Create a new script with a defaultData suitable for running against the set of DECam images of the COSMOS field as processed at NCSA. The simple validateDecam.py load just a couple of dataIds from validate_data_decam. This new script looks at 9 z-band visits.
Return pipeBase.Struct() for previous base tuples from calcPA1 and calcPA2. While technically a functional change, this is effectively a change to improve the documentation and clarity of what's being passed around. Document new files in the manifest in README.md
|
I've responded, added, squashed, and rebased. I'd like to pursue the TransformTask further in a future ticket. |
|
Be aware that I've not finished reviewing -- I'm just distracted by a docs hackathon today. I'd like to get back to this tomorrow if you/it can wait -- is that ok? |
|
Sure. Every comment is useful. |
| import lsst.pipe.base as pipeBase | ||
|
|
||
| def calcPA1(groupView, magKey): | ||
| """Calculate the photometric repeatability of measurements across a set of observations. |
There was a problem hiding this comment.
This docstring doesn't follow the standards as outlined at https://confluence.lsstcorp.org/display/LDMDG/Documentation+Standards#DocumentationStandards-FormattingoftheDocstringText. (Of course, I understand that those standards are up for debate and may be changed or replaced in the future.)
...that aside, it is a model of clarity & usefulness. Thanks!
(Same comments apply to several docstrings below, which I'm not going to call out on a case-by-case basis.)
DM-4848: Measure photometric repeatability and correctness of reported errors
Adds plots and calculation on photometric repeatability. Calculate simple RMS and more formal SRD-motivated quantities. Output to STDOUT and PNG plots in working directory.