Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-9474: "validate_drp example/runDecamTest.sh broken on decam dataset" #33

Merged
merged 1 commit into from Feb 28, 2017
Merged

DM-9474: "validate_drp example/runDecamTest.sh broken on decam dataset" #33

merged 1 commit into from Feb 28, 2017

Conversation

wmwv
Copy link
Contributor

@wmwv wmwv commented Feb 23, 2017

Add z filter to ADx, AFx to make these tests pass.

jhoblitt
jhoblitt approved these changes Feb 28, 2017
View reviewed changes
Copy link
Contributor

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable. The filter_name list is certainly duplicated a lot. It might be possible to DRY this up with the use of yaml anchors.

@wmwv
Copy link
Contributor Author

wmwv commented Feb 28, 2017

Yes, that's a good suggestion.
But the metrics+specification configuration is currently being reworked, so I'll choose to leave this slightly verbose version here.

@wmwv wmwv merged commit 6af9c2f into master Feb 28, 2017
@ktlim ktlim deleted the tickets/DM-9474 branch August 25, 2018 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhoblitt jhoblitt jhoblitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wmwv @jhoblitt