Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-9739: validate_drp broken post pybind11 merge #35

Merged
merged 1 commit into from Mar 8, 2017
Merged

DM-9739: validate_drp broken post pybind11 merge #35

merged 1 commit into from Mar 8, 2017

Conversation

wmwv
Copy link
Contributor

@wmwv wmwv commented Mar 8, 2017

int -> np.int32

jhoblitt
jhoblitt approved these changes Mar 8, 2017
View reviewed changes
Copy link
Contributor

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me but it is a little worrying that this broke.

@wmwv
Copy link
Contributor Author

wmwv commented Mar 8, 2017

It's explicitly called out in the release notes for the pybind11 merge:

https://community.lsst.org/t/pybind11-merged/1697/1

Always use numpy types for afw.schema
Use np.int32 or np.int64 to specify the type of a schema field. This was already needed for Python 3, but is now even more often needed.

@wmwv wmwv merged commit 95d4ed0 into master Mar 8, 2017
@ktlim ktlim deleted the tickets/DM-9739 branch August 25, 2018 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhoblitt jhoblitt jhoblitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wmwv @jhoblitt