DM-5159: "Please use angle and Coord where possible" #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should now properly handle wraparound.
positionRmsFromCat dtails with getting the catalog positionRms just deals with numpy arrays.
r-owen
reviewed
Mar 10, 2017
| # dist = np.arccos(np.sin(dec1)*np.sin(dec2) + np.cos(dec1)*np.cos(dec2)*np.cos(ra1 - ra2)) | ||
|
|
||
| # Could use afwCoord.angularSeparation() | ||
| # but (a) that hasn't been made accessible through the Python interface |
There was a problem hiding this comment.
It is available. So is SpherePoint.separation.
| # Could use afwCoord.angularSeparation() | ||
| # but (a) that hasn't been made accessible through the Python interface | ||
| # and (b) I'm not sure that it would be faster than the numpy interface. | ||
| # dist = afwCoord.angularSeparation(ra1-ra2, dec1-dec2, np.cos(dec1), np.cos(dec2)) |
There was a problem hiding this comment.
I suggest timing it. That should be easy to do and you might as well know. A realistic python test would take a Coord (or SpherePoint) for the average and a list of Coord (or SpherePoint) for the list of positions (In other words, don't time how long it t takes to build the list of coords) and use a list comprehension to compute dist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.