Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets/DM-4996 #4

Merged
merged 3 commits into from Feb 3, 2016
Merged

Tickets/DM-4996 #4

merged 3 commits into from Feb 3, 2016

Conversation

timj
Copy link
Member

@timj timj commented Feb 2, 2016

No description provided.

@r-owen r-owen force-pushed the tickets/DM-4996 branch 2 times, most recently from b5eafdf to 9c7e707 Compare February 2, 2016 17:00
@timj
Copy link
Member Author

timj commented Feb 2, 2016

Looks okay. The PR needs to be rebased. I'm okay with always setting DYLD_LIBRARY_PATH on OS X (as time goes by this will tend to always be relevant as older OS X systems go away).

@timj
Copy link
Member Author

timj commented Feb 2, 2016

I see the code switched again to the "always set regardless" option... I'm not going to trigger further oscillation.

@r-owen r-owen force-pushed the tickets/DM-4996 branch 2 times, most recently from d2e7574 to ff15c26 Compare February 2, 2016 18:21
@wmwv
Copy link
Contributor

wmwv commented Feb 2, 2016

README.md looks good. Thanks for updating!

Add "export DYLD_LIBRARY_PATH=${LSST_LIBRARY_PATH}"
to shell scripts to make them compatible with
System Integrity Protection on El Capitan.
Explicitly say to setup validation_drp
Add missing subdirectories to the individual commands
@r-owen r-owen merged commit b9514ac into master Feb 3, 2016
@ktlim ktlim deleted the tickets/DM-4996 branch August 25, 2018 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants