Tickets/dm 11300 #46
Tickets/dm 11300 #46
Conversation
This fixes the literal error, but I still need to fix the logical error in run, where outputPrefix isn't calculated until later.
so that it's available to all runOne* functions run in there.
python/lsst/validate/drp/validate.py
Outdated
| if outputPrefix is not None: | ||
| thisOutputPrefix = "%s_%s_" % (outputPrefix.rstrip('_'), filterName) | ||
| else: | ||
| thisOutputPrefix = "%s" % filterName |
There was a problem hiding this comment.
I'd invert the test -- avoid double negatives where possible
| @@ -137,6 +145,7 @@ def run(repo_or_json, metrics=None, makePrint=True, makePlot=True, | |||
| if not os.path.isdir(repo_or_json): | |||
| print("Could not find repo %s" % (repo_or_json)) | |||
| return | |||
| kwargs['metrics'] = metrics | |||
There was a problem hiding this comment.
Is this part of this ticket?
There was a problem hiding this comment.
Under a slight expansion of the ticket to be "fix things that MWV broke in DM-11215 so that things run again", then yes. I've expanded the ticket description to include this.
The general thing I was doing wrong was not correctly tracking which arguments were being passed through **kwargs but sometimes still needed to be inspected by the intervening functions, or which were being passed as explicit keywords to a function but not being passed along to functions called.
[Yes, this suggests some better design work is called for. I'm somewhat saving that for adapting validate_drp into a true CommandLineTask DM-5096.]
No description provided.