DM-4901: Use yaml configuration files to store camera-specific data ID and ref image information for validation testing. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wmwv
commented
Feb 13, 2016
wmwv
commented
- Add YAML config files. Use to store information about match parameters and dataIds to run and analyze.
- Refactor+Centralize to validateDrp.py and runExample.sh to put all of the logic in one place.
- validateDrp.py now accepts a directory and a configuration YAML file.
- The per-camera example scripts now are light wrappers for each camera.
Create test for loading of the config file. Move getCcdKeyName to `util` to make generally available.
Simplified names of (check,plot)AstrometryPhotometry.py to check.py, plot.py Added print.py to handle printing. Include YAML example file for CFHT. Can now run with, e.g.: validateDrp.py CFHT/output examples/runCfht.yaml
| test.log | ||
| bin/validateCfht.py | ||
| bin/validateDecam.py | ||
| *.json |
There was a problem hiding this comment.
Is it actually necessary to ignore all of this stuff? As it stands, it won't do any harm, but it's just going to cause confusion in future when somebody wants to check a JSON file into the repository. Plus I don't see the benefit at the moment -- it doesn't look like anything you're doing is actually creating JSON files, so it's not likely that they'll accidentally be committed.
There was a problem hiding this comment.
Ah, this was a bit forward-looking to DM-5121, which will create JSON output files.
wmwv
force-pushed
the
tickets/DM-4901
branch
from
a3c410b
to
fe11df4
Compare
Create Quick versions for Cfht and Decam for debugging runs. Just one CCD. Note these will fail AM2, because they're just one CCD and AM2 is looking for stars separated by 20 arcminutes. Pass MAPPER, INGEST, PROCESSCCD to runExample. runExample needs to know the CAMERA, MAPPER, the CONFIG_FILE and any specially needed versions of ingestImages.py or processCcd.py Specifically DECam needs these custom versions.
Also remove 'run' prefix from .YAML files.
Add description of Quick examples to README Use hw.logicalcpu on Darwin.
wmwv
force-pushed
the
tickets/DM-4901
branch
from
fe11df4
to
a673f37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.