DM-11571 fixes for jointcal/meas_mosaic comparison output #65
Conversation
| @@ -124,15 +124,15 @@ AM1: | |||
| - level: design | |||
| value: 10.0 | |||
| unit: marcsec | |||
| filter_names: [z, r, i, HSC-R, HSC-I] | |||
| filter_names: [u, g, r, i, z, y, HSC-U, HSC-G, HSC-R, HSC-I, HSC-Z, HSC-Y] | |||
There was a problem hiding this comment.
Unfortunately, with the verify port, this file has gone away, so we will need to port any changes here to verify_metrics. That doesn't need to be done here, but we will need to do it at some point.
| @@ -173,6 +179,8 @@ def _loadAndMatchCatalogs(self, repo, dataIds, matchRadius, | |||
| calibration. | |||
| matchRadius : afwGeom.Angle(), optional | |||
| Radius for matching. Default is 1 arcsecond. | |||
| useJointCal : bool, optional | |||
| Use jointcal/meas_mosaic outputs to calibrate positions and fluxes. | |||
There was a problem hiding this comment.
I think this needs to document skipTEx as well.
There was a problem hiding this comment.
Actually, per your later comment, the argument is going away since we're going to use the class member.
| # We don't want to put this above the first "if useJointCal block" | ||
| # because we need to use the first `butler.get` above to quickly | ||
| # catch data IDs with no usable outputs. | ||
| try: | ||
| # HSC supports these flags, which dramatically improve I/O | ||
| # performance; support for other cameras is DM-6927. | ||
| oldSrc = butler.get('src', vId, flags=SOURCE_IO_NO_FOOTPRINTS) | ||
| calexp = butler.get("calexp", vId, flags=SOURCE_IO_NO_FOOTPRINTS) | ||
| # calexp = butler.get("calexp", vId, flags=SOURCE_IO_NO_FOOTPRINTS) |
There was a problem hiding this comment.
If calexp isn't needed, this line should be deleted. Same with line 285.
| tmpCat['e2'][:] = star_e2 | ||
| tmpCat['psf_e1'][:] = psf_e1 | ||
| tmpCat['psf_e2'][:] = psf_e2 | ||
| if not self.skipTEx: |
There was a problem hiding this comment.
Perhaps I'm missing something, but you are accessing the skipTEx attribute on self which is set in the constructor. However, it is also legal to send a skipTEx parameter to this method. The two don't seem to be reconciled, which seems dangerous. I think you should just use either the attribute on self or pass it through.
There was a problem hiding this comment.
Oh! Good catch. Since this is an internal method that's called by __init__, I'm just going to use the class member and cleanup the method signature.
Fix exception to use relevant butler error and note TODO
parejkoj
force-pushed
the
tickets/DM-11571
branch
from
6ba6d9a
to
9d45d43
Compare
No description provided.