DM-11922: Add hack to convert raft, sensor x,y to one int. Allows validate_drp to run on obs_lsstSim #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses a new raftSensorToInt function in util to add a 'raft_sensor_int' entry to the visit Ids while being processed in matchreduce.py. Takes raft=(0,1), sensor=(0,2) -> 1002 This ID can then be used by multimatch, which requires ints for the dataId keys used in its indexing.
SimonKrughoff
approved these changes
Feb 6, 2018
| # Hack to support raft and sensor 0,1 IDs as ints for multimatch | ||
| if ccdKeyName == 'sensor': | ||
| ccdKeyName = 'raft_sensor_int' | ||
| for vId in dataIds: |
There was a problem hiding this comment.
I don't think this can work. Aren't you shadowing the dictionary you are trying to assign with the iterator variable?
Nevermind, I see now. you are updating the data ids. Disregard the above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a hack to allow
validate_drpto run onobs_lsstSimand any other cameras that designate detectors with, e.g., 'raft=(0,1), sensor=(0,2)' instead of a ccd or ccnum.Uses a new
raftSensorToIntfunction inutilto add a 'raft_sensor_int'entry to the visit Ids while being processed in
matchreduce.py.Takes raft=(0,1), sensor=(0,2) -> 1002
This ID can then be used by multimatch, which requires ints
for the dataId keys used in its indexing.