Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets/dm 13742 #72

Merged
merged 2 commits into from Mar 15, 2018
Merged

Tickets/dm 13742 #72

merged 2 commits into from Mar 15, 2018

Conversation

wmwv
Copy link
Contributor

@wmwv wmwv commented Mar 10, 2018

Fixes per-filter plot names to include the filter name.

@@ -52,6 +52,8 @@
formatter_class=argparse.RawDescriptionHelpFormatter)
parser.add_argument('repo', type=str,
help='path to a repository containing the output of processCcd')
parser.add_argument('--outputPrefix', '-o', type=str, default=None,
help='Define basic name prefix for output files. Can include paths. E.g., --outputPrefix="mydir/awesome_reduction" will produce "mydir/awesome_reduction_r.json" for the r-band JSON file.')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is longer than 110 char

Copy link

@hsinfang hsinfang Mar 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, don't we need to pass outputPrefix to validate.run()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Yes. Done.

Exposes existing validate.run outputPrefix option to command-line call.

Add outputPrefix to kwargs passed to run.
@wmwv wmwv merged commit 62922dc into master Mar 15, 2018
@ktlim ktlim deleted the tickets/DM-13742 branch August 25, 2018 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants