tickets/DM-5005 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty the config override files, so that defaults are used (but leave the files so users can temporarily add items). To improve clarity of the override files rename anetAstrometryConfig.py to cfhtConfig.py and delete newAstrometryConfig.py.
Hide bin/*.py and log files
Return only a Struct, not a tuple containing a Struct Document return values Return goodMatches and not "match" (get that via len(goodMatches)).
r-owen
force-pushed
the
tickets/DM-5005
branch
from
f7fcb49
to
795631b
Compare
| @@ -37,6 +37,19 @@ | |||
| from .util import getCcdKeyName, repoNameToPrefix, calcOrNone | |||
| from .io import saveKpmToJson | |||
|
|
|||
| from lsst.obs.cfht import MegacamMapper | |||
There was a problem hiding this comment.
Sorry, @r-owen I didn't catch this in my earlier review! I'm still developing my reviewing skills.
validate_drp does not depend on obs_cfht. We can't assume that this mapper is available.
objIdToCcdId should be passed the mapper in some way.
[I totally understand how this routine is useful to you.]
[Sorry, I see where it's used. But it does seem out of scope for DM-5005.]
|
This was an accident. I apologize. It was only meant to be temporary code for my own debugging purposes. I removed it on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.