Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets/dm 14928 #83

Merged
merged 2 commits into from Aug 2, 2018
Merged

Tickets/dm 14928 #83

merged 2 commits into from Aug 2, 2018

Conversation

wmwv
Copy link
Contributor

@wmwv wmwv commented Jun 28, 2018

Fixes error in DM-14765 implementation.
Instrument name now correctly calculated and UPPER CASE to get the right look-up in verify_metrics, for instruments that exist.

Copy link
Contributor

@SimonKrughoff SimonKrughoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

mapper class is a class object
I had been treating it as a string.
Use getCamera()

Fix forward referenced function that fails.
@wmwv wmwv merged commit 1d1f9b4 into master Aug 2, 2018
@ktlim ktlim deleted the tickets/DM-14928 branch August 25, 2018 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants