DM-15208 Fix disabled skipTEx option #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-15208
branch
from
e51e047
to
da6aaec
Compare
r-owen
approved these changes
Jul 27, 2018
| @@ -46,7 +44,7 @@ | |||
|
|
|||
|
|
|||
| def build_matched_dataset(repo, dataIds, matchRadius=None, safeSnr=50., | |||
| useJointCal=False): | |||
| useJointCal=False, skipTEx=False): | |||
There was a problem hiding this comment.
Do you really want to force skipTEx to False here?
There was a problem hiding this comment.
Default for it is False everywhere, which is changed by the config option.
| afx_spec_set = specs.subset(required_meta={'instrument':'HSC'}, spec_tags=[afxName,]) | ||
| adx_spec_set = specs.subset(required_meta={'instrument':'HSC'}, spec_tags=[adxName,]) | ||
| afx_spec_set = specs.subset(required_meta={'instrument': 'HSC'}, spec_tags=[afxName, ]) | ||
| adx_spec_set = specs.subset(required_meta={'instrument': 'HSC'}, spec_tags=[adxName, ]) |
There was a problem hiding this comment.
Do you really want HSC hard-coded here? The value is instrument below. I realize this is pre-existing code.
There was a problem hiding this comment.
I'm not going to modify the existing code other than to flake8 clean it: @SimonKrughoff or @wmwv would have to decide what appropriate defaults are here.
| Use jointcal/meas_mosaic outputs to calibrate positions and fluxes. | ||
| skipTEx : bool, optional | ||
| Skip TEx calculations (useful for older catalogs that don't have | ||
| PsfShape measurements). |
There was a problem hiding this comment.
Please put classes in back tickets at least for new docs, e.g. bool -> `bool`
parejkoj
force-pushed
the
tickets/DM-15208
branch
from
7728193
to
3930d47
Compare
parejkoj
force-pushed
the
tickets/DM-15208
branch
from
376a4a7
to
ecaaa75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.