DM-5121: "Add multiple-filter capabilities to validate_drp"
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmwv
force-pushed
the
tickets/DM-5121
branch
2 times, most recently
from
f325eec
to
2eeb611
Compare
Add 6 r-band images to DecamCosmos.yaml
validate.run now wraps validate.runOneFilter and identifies unique filters and then iterates through them to analyze each filter individually. When passed just a single filter as a string construct a filters array of the same length as visits and filled with the one filter name. Names of output files have the filter name included.
wmwv
force-pushed
the
tickets/DM-5121
branch
from
6f7b923
to
7faebe5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Straightfoward. Minor syntax change in building of dataIds from YAML config file.
validate.py now has an overall parsing for all filters, then hands off to do a oneFilter version of the analysis for each filter. There is no cross-filter matching done.
Improve JSON test (yes, technically out of scope, but indulge me to include it here).