Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

Tickets/dm 14868 #9

Merged
merged 5 commits into from Dec 20, 2018
Merged

Tickets/dm 14868 #9

merged 5 commits into from Dec 20, 2018

Conversation

wmwv
Copy link
Contributor

@wmwv wmwv commented Sep 20, 2018

Update curated processCcd output with HTM-ref-cat processed version.
Add explicit reprocess.sh script for reference.
Switch decamConfig.py to use MatchPessimisticBTask


setPhotocalConfigFromEups(config.calibrate.photoCal)
from lsst.meas.astrom.matchPessimisticB import MatchPessimisticBTask
config.calibrate.astrometry.matcher.retarget(MatchPessimisticBTask)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we still need to retarget the photometric matcher, or does it use the same one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obs_decam/config/processCcd.py already defaults to the HTM catalogs for both the astrometric and photometric calibration.

It's actually done this since 2017-07-20. I was previously explicitly overriding that in the validation_data_decam/decamConfig.py to use the astrometry.net files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new lines are necessary because obs_decam doesn't explicitly set MatchPessimisticBTask. Once DM-14868 is merged, it's likely that MatchPessimisticBTask will become the processCcd config default and I'll remove the lines above. I'd like to eventually remove any config customizations in the CI runs.

reprocess.sh Outdated
@@ -0,0 +1,17 @@
setup obs_decam -t w_2018_37
# To be run from within validation_data_decam repo
# were we were at DM-14868

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"were we were" --> "where we were"

@wmwv wmwv merged commit be4b166 into master Dec 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants