Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-25863: Fix and update metric generation in colorAnalysis.py #57

Merged
merged 3 commits into from Jul 16, 2020
Merged

DM-25863: Fix and update metric generation in colorAnalysis.py #57

merged 3 commits into from Jul 16, 2020

Conversation

laurenam
Copy link
Collaborator

@laurenam laurenam commented Jul 9, 2020

No description provided.

@laurenam
Move metric writing to below plot generation
dd54f45 
As of DM-22255, the plot generation is delayed to a final call to
savePlots() in the run method.  As such, the metric measurements do
not get computed and added to the verify job until after this plot
generation function has been run (otherwise we just get a verify
json file with metrics defined, but no measurement values added).
@laurenam
Add tract tag to colorAnalysis verify metrics
f47e20a
@laurenam
Fix logic for external calibration labeling
e64d7bb 
A superfluous "SFM" was getting appended when FGCM was used as the external
photometric calibration ("guessed" by the code by presence of FGCM calibration
files in the repo under consideration).  FGCM calibration has only recently
been "turned on" for HSC reprocessing, so this went unnoticed.
@laurenam laurenam merged commit d887a40 into master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yalsayyad yalsayyad yalsayyad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@laurenam @yalsayyad