Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-33453: Update pipeline references in response to RFC-775. #117

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

erinleighh
Copy link
Contributor

@erinleighh erinleighh commented Jan 29, 2024

Changed HyperSuprimeCam to HSC and DarkEnergyCamera to DECam in response to RFC-775.

Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! However, please don't merge this until at least the day after lsst/ap_pipe#150, so that we can get a daily container that uses these paths. It's a bit of unfortunate timing that this ticket got done just as we're starting a new AuxTel run...

Pinging @hsinfang so she's aware of the potential conflict.

@kfindeisen
Copy link
Member

kfindeisen commented Jan 29, 2024

Please also update tests/data/ApPipe.yaml. I missed it myself until I did a final search for references.

The good news is that file should break unit tests, so we might not have to worry about premature container builds. Though that's a very hacky solution to the problem. 😬

EDIT: Actually, did unit tests run fine with the file as is?

@kfindeisen
Copy link
Member

I've just restarted the service job based on the d_2024_01_31 container. I'll run a quick HSC integration test, and then you should be good to go!

@kfindeisen
Copy link
Member

A minimum HSC run of the full ApPipe.yaml finished without errors. Thanks for your patience!

@erinleighh erinleighh merged commit dc17fda into main Jan 31, 2024
6 checks passed
@erinleighh erinleighh deleted the tickets/DM-33453 branch January 31, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants