DM-43488: Concurrency errors in chain handling interrupt processing #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
force-pushed
the
tickets/DM-43488
branch
from
1fc6975
to
94c8ce5
Compare
The output chain strictly only needs to be handled by one pod, and is not a core feature of the export. Failure to update it should not be treated as a failure of the whole pipeline.
kfindeisen
force-pushed
the
tickets/DM-43488
branch
from
94c8ce5
to
75bc2d6
Compare
hsinfang
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR catches exceptions raised while trying to concurrently modify the central repo's output chain, handling it as something that need not terminate execution. All other registry errors raised during export should still propagate as before.