DM-39653: Prompt processing unit tests have bitrotted #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the unit tests created test DatasetRef objects that don't correspond to an existing object. Fortunately, providing a nonexistent run works for now.
ktlim
approved these changes
Jun 13, 2023
ktlim
reviewed
Jun 13, 2023
|
No, "dummy" doesn't exist (I hope that won't cause another breakage later!). The test in question manipulates collections of |
|
To confirm, you can create a |
The new Butler.exists returns False instead of raising, so some surrounding code has been changed to reflect that.
kfindeisen
force-pushed
the
tickets/DM-39653
branch
from
c7017fe
to
f097ad4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an API removal (on lsst/daf_butler#841) that was preventing
prompt_prototypefrom building.