(profile::core::puppet_master) use lsst/smee instead of inline code

The lsst/smee mod has support for both EL7 and EL8.

site/profile/manifests/core/puppet_master.pp

@@ -79,6 +79,12 @@
 
   Class['r10k::webhook::config'] -> Class['r10k::webhook']
 
+  class { 'smee':
+    url  => $smee_url,
+    path => '/payload',
+    port => 8088,
+  }
+
   # el7 systemd is too old to support periodic graceful restarts of a service unit.
   # Using cron seems slightly more obvious than creating a timer unit than triggers a one shot
   # service to restart the original service unit.
@@ -89,52 +95,6 @@
     minute  => 42,
   }
 
-  $node_pkgs = [
-    'rh-nodejs10',
-    'rh-nodejs10-npm',
-  ]
-
-  package { $node_pkgs:
-    require => Class['scl'],
-  }
-
-  exec { 'install-smee':
-    creates   => '/opt/rh/rh-nodejs10/root/usr/bin/smee',
-    command   => 'npm install --global smee-client',
-    subscribe => Package['rh-nodejs10-npm'],
-    path      => [
-      '/opt/rh/rh-nodejs10/root/usr/bin',
-      '/usr/sbin',
-      '/usr/bin',
-    ],
-  }
-
-  $service_unit = @("EOT")
-    [Unit]
-    Description=smee.io webhook daemon
-
-    [Service]
-    Type=simple
-    ExecStart=/usr/bin/scl enable rh-nodejs10 -- \
-      /opt/rh/rh-nodejs10/root/usr/bin/smee \
-      --url ${smee_url} \
-      -P /payload \
-      -p 8088
-    Restart=on-failure
-    RestartSec=10
-
-    [Install]
-    WantedBy=default.target
-    | EOT
-
-  systemd::unit_file { 'smee.service':
-    ensure    => 'present',
-    active    => true,
-    content   => $service_unit,
-    enable    => true,
-    subscribe => Exec['install-smee'],
-  }
-
   cron { 'smee':
     command => '/usr/bin/systemctl restart smee > /dev/null 2>&1',
     user    => 'root',

spec/classes/core/puppet_master_spec.rb

@@ -5,6 +5,14 @@
 describe 'profile::core::puppet_master' do
   it { is_expected.to compile.with_all_deps }
 
+  it do
+    is_expected.to contain_class('smee').with(
+      url: 'https://foo.example.org',
+      path: '/payload',
+      port: 8088,
+    )
+  end
+
   it do
     is_expected.to contain_cron('webhook').with_command('/usr/bin/systemctl restart webhook > /dev/null 2>&1')
   end

spec/fixtures/hieradata/common.yaml

@@ -11,7 +11,7 @@ profile::core::monitoring::database: "foo"
 profile::core::monitoring::password: "foo"
 profile::core::monitoring::url: "foo"
 profile::core::monitoring::username: "foo"
-profile::core::puppet_master::smee_url: "https://smee.io/abc"
+profile::core::puppet_master::smee_url: "https://foo.example.org"
 profile::icinga::agent::ca_salt: "foo"
 profile::icinga::agent::credentials_hash: "foo"
 profile::icinga::master::api_name: "foo"

spec/hosts/roles/foreman_spec.rb

@@ -139,6 +139,14 @@
   end
 
   it { is_expected.to contain_foreman_config_entry('template_sync_branch').with_value(site) }
+
+  it do
+    is_expected.to contain_class('smee').with(
+      url: smee_url,
+      path: '/payload',
+      port: 8088,
+    )
+  end
 end
 
 role = 'foreman'
@@ -157,6 +165,7 @@
           site: site,
         }
       end
+      let(:smee_url) { 'https://smee.io/lpxrggGObEn5YTA' }
 
       describe 'foreman.dev.lsst.org', :site, :common do
         let(:site) { 'dev' }