Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(node/lsstcam-vac.cp.lsst.org) deploy host as el9 #1150

Open
wants to merge 2 commits into
base: production
Choose a base branch
from
Open

(node/lsstcam-vac.cp.lsst.org) deploy host as el9 #1150

wants to merge 2 commits into from

Conversation

dtapiacl
Copy link
Contributor

No description provided.

@dtapiacl dtapiacl added the enhancement New feature or request label May 14, 2024
@dtapiacl dtapiacl self-assigned this May 14, 2024
@dtapiacl dtapiacl force-pushed the IT-5342_lsstcam_vac branch 2 times, most recently from e4b0fcb to 1d3b2a5 Compare May 14, 2024 16:14
jhoblitt
jhoblitt requested changes May 15, 2024
View reviewed changes
hieradata/node/lsstcam-vac.cp.lsst.org.yaml Show resolved Hide resolved
hieradata/node/lsstcam-vac.cp.lsst.org.yaml Outdated Show resolved Hide resolved
spec/hosts/nodes/lsstcam-vac.cp.lsst.org_spec.rb Outdated Show resolved Hide resolved
@dtapiacl dtapiacl force-pushed the IT-5342_lsstcam_vac branch 3 times, most recently from 14368d7 to 70221be Compare May 15, 2024 23:45
@dtapiacl dtapiacl requested a review from jhoblitt May 15, 2024 23:45
@dtapiacl dtapiacl requested a review from jhoblitt May 23, 2024 15:20
jhoblitt
jhoblitt approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for updating ipam.

jhoblitt
jhoblitt requested changes May 30, 2024
View reviewed changes
Copy link
Member

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash 70221be

@dtapiacl
Copy link
Contributor Author

Please squash 70221be

Commit was squashed on to: 0d46834

@dtapiacl dtapiacl requested a review from jhoblitt May 30, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmorris glennmorris glennmorris approved these changes

@cbarria cbarria Awaiting requested review from cbarria

@tony-johnson tony-johnson Awaiting requested review from tony-johnson

@jhoblitt jhoblitt Awaiting requested review from jhoblitt

Requested changes must be addressed to merge this pull request.

Assignees

@dtapiacl dtapiacl

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtapiacl @jhoblitt @glennmorris