Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coredev production #125

Merged
merged 42 commits into from
May 10, 2020
Merged

Coredev production #125

merged 42 commits into from
May 10, 2020

Conversation

hreinking
Copy link
Contributor

rebasing this branch is getting harder and harder, so I'm merging the dev site and start doing the same approach as with the other production branches

hieradata/site/dev.yaml Outdated Show resolved Hide resolved
hieradata/org/lsst/role/dev_hyp.yaml Show resolved Hide resolved
Co-authored-by: Adrien Thebo <athebo@lsst.org>
@hreinking hreinking requested a review from adrienthebo May 8, 2020 21:50
Copy link
Contributor

@adrienthebo adrienthebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small concerns, no blockers. Take another pass of cleanup and then good for merge - though since this is non-critical work I suggest deferring the merge until Monday.

hieradata/site/dev.yaml Show resolved Hide resolved
hieradata/site/dev/role/graylog.yaml Outdated Show resolved Hide resolved
hieradata/org/lsst/role/dev_hyp.yaml Show resolved Hide resolved
hieradata/site/dev.yaml Outdated Show resolved Hide resolved
@hreinking hreinking requested a review from adrienthebo May 8, 2020 22:05
Copy link
Member

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like the hypervisor libvirt setup to be de-duplicated but that can be done post-merge.

@jhoblitt jhoblitt merged commit 93b94e8 into master May 10, 2020
@jhoblitt jhoblitt deleted the coredev_production branch May 10, 2020 00:07
@jhoblitt jhoblitt restored the coredev_production branch May 10, 2020 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants