Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCS changes for Tucson test-stand #464

Merged
merged 9 commits into from
Nov 9, 2021
Merged

CCS changes for Tucson test-stand #464

merged 9 commits into from
Nov 9, 2021

Conversation

glennmorris
Copy link
Contributor

@glennmorris glennmorris commented Nov 8, 2021

Changes related to Tucson test-stand. The only change that applies elsewhere is the one to hieradata/cluster/comcam-ccs.yaml, but it should be a no-op.

These changes should address most of the issues from
https://jira.lsstcorp.org/browse/IT-3277?jql=project%20%3D%20IT%20AND%20resolution%20%3D%20Unresolved%20AND%20labels%20%3D%20tucson-test-stand%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC

@glennmorris glennmorris changed the title Ccs tu tts CCS changes for Tucson test-stand Nov 8, 2021
@glennmorris
Copy link
Contributor Author

Force pushed to fix a last minute typo, will close and reopen for clarity.

@glennmorris glennmorris closed this Nov 8, 2021
@glennmorris
Copy link
Contributor Author

Seems github doesn't let me replace this pull request, so I will reopen it.
Sorry for making even more noise!

@glennmorris glennmorris reopened this Nov 8, 2021
Copy link
Member

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glennmorris Do you want me to merge this and move the tu_production branch forward?

@@ -0,0 +1,10 @@
---
ccs_site: "tucson"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhoblitt Yes, if you are ok with it, please merge it, thanks.

ccs_site: "tucson"

## FIXME this should be "comcam-mcm-dds", same as real comcam.
ccs_sal::dds_interface: "140.252.147.52"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dds interface still hasn't shown up in foreman for some reason. I'll sort this out tomorrow.

## Installation of DAQ client:
## Download DAQ tarfile, extract it, create /etc/ccs config files.

class profile::ccs::daq_client (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be completely stand alone and could be in an external module. There are a bunch of example of things in the tree that should be in an external module as they aren't a composition. I don't object to merging this now but it should probably be moved external at some point in the future in the interest of keeping our profile tree small.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will try to separate it out at some point in the future.

@@ -3,6 +3,7 @@ classes:
- "profile::core::common"
- "profile::ccs::common"
- "profile::ccs::tomcat"
- "profile::ccs::graphical"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI - I usually sort the inclusion list but the linter doesn't care.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted.

@jhoblitt jhoblitt merged commit 73b08dd into master Nov 9, 2021
@jhoblitt jhoblitt deleted the ccs-tu-tts branch November 9, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants