Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(spec) reduce role catchall to one site per OS at random #623

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

jhoblitt
Copy link
Member

@jhoblitt jhoblitt commented Aug 2, 2022

As a performance optimization, test with only one site. If it is
important that a role is better tested, it should have its own spec
file.

@jhoblitt jhoblitt requested a review from cbarria August 2, 2022 15:45
jhoblitt added a commit that referenced this pull request Aug 2, 2022
jhoblitt added a commit that referenced this pull request Aug 3, 2022
jhoblitt added a commit that referenced this pull request Aug 3, 2022
Copy link
Contributor

@cbarria cbarria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing would be overkill if tried on every Site per OS 👍

@jhoblitt
Copy link
Member Author

jhoblitt commented Aug 3, 2022

I would prefer to test all sites but I couldn't figure out a sane way to parallelize the catchall tests. If/when individual spec files are created for each role, then that role will be tested in parallel with other roles.

As a performance optimization, test with only one site.  If it is
important that a role is better tested, it should have its own spec
file.
@jhoblitt jhoblitt merged commit d041ebe into master Aug 3, 2022
@jhoblitt jhoblitt deleted the IT-3057/catchall-rng branch August 3, 2022 18:40
jhoblitt added a commit that referenced this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants