-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
puppet6 -> puppet7 migration #639
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoblitt
force-pushed
the
IT-2937/puppet7
branch
2 times, most recently
from
August 22, 2022 22:47
b76771c
to
ac638f2
Compare
jhoblitt
force-pushed
the
IT-2937/puppet7
branch
from
August 22, 2022 23:04
ac638f2
to
25a4776
Compare
cbarria
approved these changes
Aug 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump puppet to v7.
To make it easier to sort the file.
To pickup misc fixes and EL9 support.
Attempt to resolve: Aug 18 22:30:27 foreman.dev.lsst.org puppetserver[7154]: /etc/puppetlabs/code/environments/IT_2937_puppet7/modules/icinga2/lib/puppet_x/icinga2/utils.rb:365: warning: deprecated Object#=~ is called on TrueClass; it always returns nil
To initially be used for a containerized version of foreman_envsync. Note that spec coverage is not part of this commit as there is a docker refactor in another branch that addes a `docker` example group.
puppet6 aio bundles the oauth gem but it is not bundled with puppet7 aio. Most of the native types in `theforeman/foreman` require this gem to be present. See: theforeman/puppet-foreman#1077
jhoblitt
force-pushed
the
IT-2937/puppet7
branch
from
August 23, 2022 22:27
25a4776
to
6805be8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work depends on other PRs and will need to version strings updated after they are merged.
Depends on: