Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker cleanup/update #643

Merged
merged 6 commits into from
Aug 29, 2022
Merged

docker cleanup/update #643

merged 6 commits into from
Aug 29, 2022

Conversation

jhoblitt
Copy link
Member

Presently, all roles are using the same docker version. Removing the hiera keys from the common hierarchy and relying the defaults is both DRYing and removes versionlocks which will have to be updated and maintained for EL8.

The 4.4.0 release incorporates puppetlabs/puppetlabs-docker#783.

It also includes a fix for the docker swarm facts generating error
messages in syslog. puppetlabs/puppetlabs-docker#817
Setting this param ensures that the docker-ce-cli package will be
installed.
/etc/docker is normally created by dockerd the first time the service is
started.  However, we would like daemon.json to be in place prior to the
first startup.
@jhoblitt jhoblitt requested a review from cbarria August 26, 2022 20:49
jhoblitt added a commit that referenced this pull request Aug 26, 2022
Copy link
Contributor

@cbarria cbarria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

part of the cleanup for el8 👍

@jhoblitt jhoblitt merged commit ba7cd7a into master Aug 29, 2022
@jhoblitt jhoblitt deleted the IT-3057/docker-update branch August 29, 2022 16:54
jhoblitt added a commit that referenced this pull request Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants