Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generic preparations for EL8 #670

Merged
merged 14 commits into from
Oct 19, 2022
Merged

generic preparations for EL8 #670

merged 14 commits into from
Oct 19, 2022

Conversation

jhoblitt
Copy link
Member

No description provided.

@jhoblitt jhoblitt mentioned this pull request Oct 14, 2022
Merged
@jhoblitt jhoblitt force-pushed the IT-3057/el8-dnscache-int-names branch from cf4ca02 to d135af0 Compare October 14, 2022 23:06
cbarria
cbarria reviewed Oct 17, 2022
View reviewed changes
Copy link
Contributor

@cbarria cbarria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most changes condition things to only happend on EL7 or 8, just that question about testing.

spec/spec_helper.rb Outdated Show resolved Hide resolved
@jhoblitt jhoblitt force-pushed the IT-3057/el8-dnscache-int-names branch from d135af0 to efaa0d5 Compare October 18, 2022 18:01
@jhoblitt jhoblitt force-pushed the IT-3057/el8-dnscache-int-names branch from efaa0d5 to 281ff48 Compare October 18, 2022 21:30
@jhoblitt jhoblitt force-pushed the IT-3057/el8-dnscache-int-names branch from 281ff48 to e86ad3f Compare October 18, 2022 21:32
@jhoblitt jhoblitt requested a review from cbarria October 18, 2022 21:44
@jhoblitt jhoblitt force-pushed the IT-3057/el8-dnscache-int-names branch from e86ad3f to 78c22f6 Compare October 18, 2022 22:58
@jhoblitt jhoblitt changed the title (dnscache role/nodes) prepare for EL8 stable interfaces names (dnscache role/nodes) prepare for EL8 Oct 19, 2022
@jhoblitt jhoblitt changed the title (dnscache role/nodes) prepare for EL8 generic preparations for EL8 Oct 19, 2022
cbarria
cbarria approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@cbarria cbarria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of things but everything looks good 👍

@jhoblitt jhoblitt merged commit f8ed4f9 into master Oct 19, 2022
@jhoblitt jhoblitt deleted the IT-3057/el8-dnscache-int-names branch October 19, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbarria cbarria cbarria approved these changes

@hreinking hreinking Awaiting requested review from hreinking

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jhoblitt @cbarria