Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(profile::core::gpio) fwv #982

Merged
merged 3 commits into from
Nov 16, 2023
Merged

(profile::core::gpio) fwv #982

merged 3 commits into from
Nov 16, 2023

Conversation

jhoblitt
Copy link
Member

No description provided.

@jhoblitt jhoblitt added the enhancement New feature or request label Nov 16, 2023
@jhoblitt jhoblitt marked this pull request as draft November 16, 2023 00:04
@jhoblitt jhoblitt marked this pull request as ready for review November 16, 2023 00:13
glennmorris
glennmorris reviewed Nov 16, 2023
View reviewed changes
Copy link
Contributor

@glennmorris glennmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is fine, assuming it will be a no-op on RHEL7?

@jhoblitt
Copy link
Member Author

I guess this is fine, assuming it will be a no-op on RHEL7?

Correct. There will be no char device to match the name pattern, so nothing will happen.

glennmorris
glennmorris previously approved these changes Nov 16, 2023
View reviewed changes
@glennmorris
Copy link
Contributor

Actually, now that I think about it, shouldn't this be part of the ccs_hcu module?

@glennmorris glennmorris dismissed their stale review November 16, 2023 03:33

I think changes might be better in ccs_hcu module

@glennmorris glennmorris self-requested a review November 16, 2023 03:33
@jhoblitt
Copy link
Member Author

@glennmorris I feel like this is really in role/profile territory. We are going to use the same udev rules for rpis so I think I'm going to turn this into a profile class.

@jhoblitt jhoblitt marked this pull request as draft November 16, 2023 15:23
@jhoblitt jhoblitt force-pushed the IT-4871/gpio-udev branch 2 times, most recently from b69ccc5 to 1006221 Compare November 16, 2023 19:06
@jhoblitt jhoblitt changed the title (role/atshcu) add udev rule for /dev/gpiochip* (profile::core::gpio) fwv Nov 16, 2023
@jhoblitt
Copy link
Member Author

This has been reworked to add a new profile::core::gpio profile.

glennmorris
glennmorris approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@glennmorris glennmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@jhoblitt jhoblitt force-pushed the IT-4871/gpio-udev branch 2 times, most recently from bd92ce6 to 071b5e6 Compare November 16, 2023 19:26
@jhoblitt jhoblitt marked this pull request as ready for review November 16, 2023 21:45
@jhoblitt jhoblitt merged commit 8b54d6e into production Nov 16, 2023
12 checks passed
@jhoblitt jhoblitt deleted the IT-4871/gpio-udev branch November 16, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmorris glennmorris glennmorris approved these changes

@cbarria cbarria Awaiting requested review from cbarria

@csilva-cl csilva-cl Awaiting requested review from csilva-cl

@dtapiacl dtapiacl Awaiting requested review from dtapiacl

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jhoblitt @glennmorris