You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some discontinuity issues with the curves, due to instrument calibration issues, which put us on hold with this update for a while. According to Chuck, "as a matter of policy we should always update with our best current knowledge as we receive it. "
Hi @bxin - wow those notebooks worked out nicely (especially I was comforted by the 'Confirm Updates' one.
Looks ready to update.
Do you want to update the README in the top level of the directory with a comment about the update? - The new 'release'/tag would be 1.6 and the information related to the update would simply be that the mirror reflectivity was updated based on measurements from coating samples from June 2019. You could add a link to this PR, which might be helpful. If that is the total of the update info required, I'm happy to do that when actually tagging/creating the release too.
(After merge, I'm happy to do the actual tagging of this repo and then the update of lsst/throughputs - just let me know when the merge is complete).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates contains mirror throughput curves from the June 2019 coating samples.
I am following the update process as outlined here.
https://github.com/lsst-pst/syseng_throughputs/blob/update/l2l1/RepoProcess.md
There are some discontinuity issues with the curves, due to instrument calibration issues, which put us on hold with this update for a while. According to Chuck, "as a matter of policy we should always update with our best current knowledge as we receive it. "