DM-37634: Update logBrowser to take ready-made butler #16
Conversation
| like. If this is the case, take the first part of the message that is | ||
| common among the ones you would like to be classed together, and add it to | ||
| the class property ``SPECIAL_ZOO_CASES`` to declare a new type of error | ||
| animal. | ||
|
|
||
| example usage: |
There was a problem hiding this comment.
You can put this into its own Numpydoc section, i.e.:
Examples
--------
There was a problem hiding this comment.
The reason I didn't want to do that is that sometimes those are actually considered literally runnable, and this one certainly isn't and could not really ever be, realistically, given the need for a butler and a collection.
There was a problem hiding this comment.
Fair enough - in which case, as it is looks good!
|
Thanks Merlin, interesting stuff! Apologies for going out of the bounds of the changes a couple of times! I restricted myself from recommending more file-wide changes (e.g., single quotes to double, one-line doc strings wrapped to a single line) - this looks good to me! 👍 |
| SPECIAL_ZOO_CASES = [ | ||
| 'with gufunc signature (n?,k),(k,m?)->(n?,m?)', | ||
| ] |
There was a problem hiding this comment.
PS - I think my comment may have been lost in the noise, but you can wrap this onto one line if you wish (the trailing comma led me to put it as above, but one line works just fine).
There was a problem hiding this comment.
There will almost certainly be new things added to that, so the one-line-per-item thing should fit better in the long run here, I think.
No description provided.