DM-38013: Fix where focus_z value comes from #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
reviewed
Feb 15, 2023
| @@ -52,6 +52,10 @@ class FitResult: | |||
| sigma: float | |||
|
|
|||
|
|
|||
| def getFocusFromHeader(exp): | |||
| return float(exp.visitInfo.focusZ) | |||
There was a problem hiding this comment.
Is it correct to refer to the visitInfo as a “header”? Also, this one-liner seems like overkill for its own (undocumented) function 😉
There was a problem hiding this comment.
Fair cop on both accounts - I've renamed it to getFocusFromExposure and added docs. I think a function is good though, because even though it's a one-liner, if/when it moves again, or we find out the we need to apply some weird offset/transform from the EFD, we only have to change that in one place.
laurenam
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.