DM-35404: Add tests for focus analyses #18
Conversation
| import unittest | ||
| from typing import Iterable | ||
|
|
||
| import lsst.utils.tests |
There was a problem hiding this comment.
Minor point, but shouldn't this import happen after lsst.summit.utils?
There was a problem hiding this comment.
Is this referring to fact I'm importing the tested code after the mpl.use('Agg') line? This is because you have to set the matplotlib backend before any other code which imports matplotlib does (hence the #noqa: E402 line decorators) or people have plots pop up.
There was a problem hiding this comment.
No, this is a very minor point. Shouldn't the order of imports be:
...
lsst.summit.utils
lsst.utils.tests
There was a problem hiding this comment.
Ohhhh, there's no isort over here, and I've made minimal effort anywhere to keep things alphabetical, so that didn't even occur to me! Look elsewhere in the package and you'll see the imports are a free-for-all! I'm considering going pre-commit + black + isort etc at some point though, but that's definitely another ticket 🙂
No description provided.