Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-34703: Assess new results from QuickFrameMeasurementTask #28

Merged
merged 3 commits into from Dec 1, 2023

Conversation

cmsaunders
Copy link
Contributor

No description provided.

Copy link

@jmeyers314 jmeyers314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just the one comment.


if __name__ == '__main__':

butler = butlerUtils.makeDefaultLatissButler(embargo=True)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put some of these options into an argparse instead of hard-coding them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good suggestion.

@cmsaunders cmsaunders merged commit b8e4f80 into main Dec 1, 2023
1 check passed
@cmsaunders cmsaunders deleted the tickets/DM-34703 branch December 1, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants