DM-43043: Add AuxTel slew analysis plotting #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfisherlevine
force-pushed
the
tickets/DM-43043
branch
from
1f9e034
to
7efd744
Compare
mfisherlevine
force-pushed
the
tickets/DM-43043
branch
from
7efd744
to
90bc5bb
Compare
fritzm
reviewed
Feb 29, 2024
| postPadding=postPadding, | ||
| warn=False # most commands will not be issue so we expect many empty queries | ||
| ) | ||
| if not data.empty: |
There was a problem hiding this comment.
Do you need this if? Won't the iterrows() below just execute the body zero times if empty? ("I think it is more clear this way" is an acceptable answer, since performance impact is clearly negligible.)
There was a problem hiding this comment.
No no, you're exactly right - I don't pandas all that often, and there was a place where I did need to check, because I was merging dataframes, and if it was empty then the merge would fail due to the missing columns to merge on, and I'd just mis-extrapolated from that.
fritzm
reviewed
Feb 29, 2024
|
|
||
| This function plots the mount position data for the entire time range of | ||
| the exposures, regardless of whether the exposures are contiguous or not. | ||
| The exposures are be shaded in the plot to indicate the time range for each |
fritzm
approved these changes
Feb 29, 2024
mfisherlevine
force-pushed
the
tickets/DM-43043
branch
from
90bc5bb
to
ddf0e7d
Compare
mfisherlevine
force-pushed
the
tickets/DM-43043
branch
from
ddf0e7d
to
2803eae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.