Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-43209: Add type annotations #35

Merged
merged 14 commits into from
May 1, 2024
Merged

DM-43209: Add type annotations #35

merged 14 commits into from
May 1, 2024

Conversation

kkeijuro
Copy link

Add type annotations to summit_extras

@mfisherlevine mfisherlevine changed the title Tickets/dm 43209 DM-43209: Add type annotations Mar 13, 2024
@kkeijuro kkeijuro force-pushed the tickets/DM-43209 branch 4 times, most recently from 48ab693 to 15a06e1 Compare March 18, 2024 14:24
python/lsst/summit/extras/animation.py Show resolved Hide resolved
python/lsst/summit/extras/animation.py Outdated Show resolved Hide resolved
python/lsst/summit/extras/animation.py Outdated Show resolved Hide resolved
python/lsst/summit/extras/animation.py Outdated Show resolved Hide resolved
python/lsst/summit/extras/animation.py Outdated Show resolved Hide resolved
python/lsst/summit/extras/slewTiming.py Outdated Show resolved Hide resolved
python/lsst/summit/extras/slewTiming.py Outdated Show resolved Hide resolved
python/lsst/summit/extras/slewTiming.py Outdated Show resolved Hide resolved
python/lsst/summit/extras/slewTiming.py Outdated Show resolved Hide resolved
python/lsst/summit/extras/slewTiming.py Outdated Show resolved Hide resolved
@timj
Copy link
Collaborator

timj commented Mar 18, 2024

Two general comments:

  1. Use from __future__ import annotations at the top of each file.
  2. Don't use Dict, Tuple or Set etc. Use the standard python classes. You can update what you have with ruff --select=UP --fix .

Cristobal Pio Garcia and others added 2 commits April 29, 2024 07:48
@mfisherlevine mfisherlevine merged commit f383b3c into main May 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants