Do required manual fixups for black and isort

python/lsst/summit/utils/imageExaminer.py

@@ -496,7 +496,7 @@ def plotSurface(self, ax=None, useColor=True):
             plotDirect = True
 
         if useColor:
-            surf = ax.plot_surface(
+            surf = ax.plot_surface(  # noqa: F841
                 self.xx,
                 self.yy,
                 self.data,
@@ -507,7 +507,7 @@ def plotSurface(self, ax=None, useColor=True):
                 alpha=0.9,
             )
         else:
-            surf = ax.plot_wireframe(
+            surf = ax.plot_wireframe(  # noqa: F841
                 self.xx,
                 self.yy,
                 self.data,
@@ -749,7 +749,8 @@ def translateStats(imStats, mappingDict):
                 lines.append("")
                 continue
 
-            if type(value) == float or isinstance(value, np.floating):
+            # native floats are not np.floating so must check both
+            if isinstance(value, float) or isinstance(value, np.floating):
                 value = f"{value:,.3f}"
             if k == "centroid":  # special case the only tuple
                 value = f"{value[0]:.1f}, {value[1]:.1f}"

python/lsst/summit/utils/nightReport.py

@@ -417,7 +417,9 @@ def calcShutterTimes(self):
         return result
 
     def printShutterTimes(self):
-        """Print out the shutter efficiency stats in a human-readable format."""
+        """Print out the shutter efficiency stats in a human-readable
+        format.
+        """
         if not HAVE_HUMANIZE:
             self.log.warning("Please install humanize to make this print as intended.")
         timings = self.calcShutterTimes()

python/lsst/summit/utils/tmaUtils.py

@@ -487,7 +487,8 @@ def getPlotTime(time):
     # Add title with the event name, type etc
     dayObsStr = dayObsIntToString(event.dayObs)
     title = (
-        f"{dayObsStr} - seqNum {event.seqNum} (version {event.version})"  # top line, rest below
+        # top line is the event title, the details go on the line below
+        f"{dayObsStr} - seqNum {event.seqNum} (version {event.version})"
         f"\nDuration = {event.duration:.2f}s"
         f" Event type: {event.type.name}"
         f" End reason: {event.endReason.name}"

tests/test_efdUtils.py

@@ -31,7 +31,7 @@
 from utils import getVcr
 
 import lsst.utils.tests
-from lsst.summit.utils.efdUtils import (  # calcNextDay,  # this is indirectly tested by test_getDayObsAsTimes()
+from lsst.summit.utils.efdUtils import (
     astropyToEfdTimestamp,
     clipDataToEvent,
     efdTimestampToAstropy,

tests/test_nightReport.py

@@ -101,7 +101,9 @@ def test_getExpRecordDictForDayObs(self):
         return
 
     def test_getObsInfoAndMetadataForSeqNum(self):
-        """Test that getObsInfoAndMetadataForSeqNum returns the correct types."""
+        """Test that getObsInfoAndMetadataForSeqNum returns the correct
+        types.
+        """
         seqNum = self.seqNums[0]
         obsInfo, md = self.report.getObsInfoAndMetadataForSeqNum(seqNum)
         self.assertIsInstance(obsInfo, ObservationInfo)
@@ -147,7 +149,9 @@ def test_getTimeDeltas(self):
         return
 
     def test_makeStarColorAndMarkerMap(self):
-        """Test the color map maker returns a dict of ColorAndMarker objects."""
+        """Test the color map maker returns a dict of ColorAndMarker
+        objects.
+        """
         cMap = self.report.makeStarColorAndMarkerMap(self.report.stars)
         self.assertEqual(len(cMap), len(self.report.stars))
         self.assertIsInstance(cMap, dict)
@@ -210,7 +214,9 @@ def test_getDatesForSeqNums(self):
         self.assertTrue(all(isinstance(seqNum, datetime.datetime) for seqNum in dateTimeDict.values()))
 
     def test_doesNotRaise(self):
-        """Tests for things which are hard to test, so just make sure they run."""
+        """Tests for things which are hard to test, so just make sure they
+        run.
+        """
         self.report.printShutterTimes()
         for sample, includeRaw in itertools.product((True, False), (True, False)):
             self.report.printAvailableKeys(sample=sample, includeRaw=includeRaw)

tests/test_tmaUtils.py

@@ -152,7 +152,9 @@ def test_tmaInit(self):
         self.assertTrue(tma._isValid)
 
     def test_tmaReferences(self):
-        """Check the linkage between the component lists and the _parts dict."""
+        """Check the linkage between the component lists and the _parts
+        dict.
+        """
         tma = TMAStateMachine()
 
         # setting one axis should not make things valid