Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-36201: Add force remake option to bestEffortIsr #24

Merged
merged 2 commits into from Oct 21, 2022

Conversation

mfisherlevine
Copy link
Contributor

No description provided.

This also significantly improves the test coverage
as now the actual task will always run instead of it usually
just loading a pre-made image from the whatever the underlying
repo is.
Copy link

@czwa czwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a bit to work through all the logic, but this seems correct to me.

@mfisherlevine mfisherlevine merged commit 54a9da1 into main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants