Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-34250: Rewrite the night reporter #29

Merged
merged 38 commits into from Dec 16, 2022
Merged

DM-34250: Rewrite the night reporter #29

merged 38 commits into from Dec 16, 2022

Conversation

mfisherlevine
Copy link
Contributor

No description provided.

@mfisherlevine
Data loading basically done
dee1d0f
@mfisherlevine
Airmass plotting working
7735703 
Bug fixes in data loading
Old functions copied in
@mfisherlevine
Polar plots working
63a22af
@mfisherlevine
Add full option to rebuild()
4037e90
@mfisherlevine
Add tests from other package - currently fails
5b8ce01
@mfisherlevine
Add copyright, add TODO, fix wrong args bug
ea171b0
@mfisherlevine
Add save and load, mainly for development work
13dd3ac
@mfisherlevine
Add getFieldNameAndTileNumber and tests
ffe2428
@mfisherlevine
Add option not to warn on field/tile check
31fcfac
@mfisherlevine
Add filtering of observed targets
4f7b109
@mfisherlevine
First pass at printObsTable()
f5716eb
@mfisherlevine
Start on night-start code, add sample option to printKeys
7b01dd4
@mfisherlevine
Add None protection to target scraping
1113a3b
@mfisherlevine
Fix flake8 errors
7425905
@mfisherlevine
Add shutter efficiency code
01ec2eb
@mfisherlevine
Add observation gaps calculation and print
e65b3b6
@mfisherlevine
Fix printObsTable up enough for now
0aaffef
@mfisherlevine
Change to 1 dp for shutter times
64bf8af
@mfisherlevine
Fix off-by-one error in gap finding
62ad42a
@mfisherlevine
Protect import of humanize package until RFC-896 is done.
3dd4062 
Remove hard coding of gap threshold
@mfisherlevine
Add docs
7d7aade
@mfisherlevine
Add TODO to remove header scraping once possible
5b4ec84
@mfisherlevine
Lots of progress on tests but not done yet
4a8b88e
@mfisherlevine
Suppress warnings on load, fix loading bug
cb35678
@mfisherlevine
Rename getNightStartSeqNum to getObservingStartSeqNum
c656fdf 
Add an includeCalibs bool to getObsGaps
@mfisherlevine
Tests passing, must remove temp hack to speed them up before merge
aef2d1f
@mfisherlevine
Change prints to logs
761f3e0
@mfisherlevine
Import ensure_iterable and remove my version
92f4f2a
@mfisherlevine
Add lots of tests
8a2cf9e
@mfisherlevine
Add test for color marker map
a4298fe
sr525
sr525 reviewed Dec 15, 2022
View reviewed changes
tests/test_nightReport.py Outdated
self.report.printObsTable()

# newline for each row plus header line, plus the line with dashes
self.assertEqual(len(fake_stdout.mock_calls), 2*(self.nImages+2))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • with no spaces.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The + is the problem here without the spaces, not the *, right?

@mfisherlevine mfisherlevine merged commit b0d32f1 into main Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sr525 sr525 sr525 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mfisherlevine @sr525