Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-37309: Nominally bring NightReport channel online #35

Merged
merged 32 commits into from Mar 9, 2023

Conversation

mfisherlevine
Copy link
Contributor

Realistically now mostly other urgent fix-ups which had to be done while I had this ticket open and deployed on the summit.

@mfisherlevine mfisherlevine force-pushed the tickets/DM-37309 branch 6 times, most recently from 57c893e to 80e25ed Compare February 22, 2023 21:36
Copy link
Contributor

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was very much a review of the trees, not the forest, but only minor comments.

python/lsst/summit/utils/utils.py Show resolved Hide resolved
python/lsst/summit/utils/nightReport.py Show resolved Hide resolved
tests/test_nightReport.py Show resolved Hide resolved
python/lsst/summit/utils/nightReport.py Show resolved Hide resolved
python/lsst/summit/utils/utils.py Show resolved Hide resolved
python/lsst/summit/utils/astrometry/utils.py Outdated Show resolved Hide resolved
@@ -143,3 +143,4 @@ def plot(exp, icSrc=None, filteredSources=None, saveAs=None,

plt.gcf().clear()
del fig
del data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this still isn't working, you might want to try gc.collect(). If that doesn't work, @natelust is the the expert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants