DM-38385: Write fastStarTracker analysis code #37
Conversation
Bugfix to consistency check of single results Update and improve source printing
Some slight renaming, adding local-coordinates centroids and flake8 fixups.
Some small bug fixes in the images width/height checking
|
|
||
| def checkResultConsistency(results, maxAllowableShift=5, silent=False): | ||
| """Check if a set of results are self-consistent. | ||
|
|
There was a problem hiding this comment.
How likely is it that you will have issues with sources at the edge of detectors? Having the brightest star at an edge seems like it will have a lot of unwanted consequences if it scatters or drifts off the detector.
There was a problem hiding this comment.
Quite likely, and I totally agree that will cause problems. That was kind of the thrust of the consistency checking helper function. My thinking is that if it slips off the edge the you either get a massive jump in centroid, or a different number of source counts, or a huge jump in brightness, or something else. Hopefully that will help people find things when it's happening, but I don't think there's much that can be done about it, at this stage at least.
There was a problem hiding this comment.
If it looks necessary, I think that coming back to all this code and implementing a better way of doing source association between the images would be a good plan, but 1) this was all written on a plane, and 2) all the data so far has no problems in source association, so I just didn't need to do it, and so didn't given the great urgency with all this stuff 🙂
mfisherlevine
force-pushed
the
tickets/DM-38385
branch
from
9e589dd
to
979ba3e
Compare
mfisherlevine
force-pushed
the
tickets/DM-38385
branch
from
6395b04
to
8c49679
Compare
No description provided.