Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-32940: Use the new Butler.exists API, replacing datasetExists #47

Merged
merged 2 commits into from Jun 7, 2023

Conversation

timj
Copy link
Contributor

@timj timj commented Jun 2, 2023

@timj
Copy link
Contributor Author

timj commented Jun 2, 2023

@mfisherlevine I'm not entirely sure how you want to play this. Do you have users of your utility datasetExists function outside of this package? Are you going to be running this code with an old butler that doesn't have .exists()? The comment associated with the utility function indicated you were happy to remove the function when the new API exists.

@mfisherlevine
Copy link
Contributor

As discussed OOB, I'm not too worried about users, but there's one instance in summit_extras and two in rubintv_production, both of which I'm happy to fix up later, but adding a deprecation warning for now, so that stacks can be updated with the coming weekly and then make use of it, would be a much easier path to getting this removed. But yes, to the "should it be removed", very much so, the intent was indeed always to get rid of that (and in fact as much else in this file as possible tbh!)

Copy link

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@timj timj merged commit 0cbd11e into main Jun 7, 2023
1 check passed
@timj timj deleted the tickets/DM-32940 branch June 7, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants