DM-41807: Add padding to clipDataToEvent #70
Conversation
| self.assertGreater(len(clippedPaddedData), 0) | ||
| self.assertLess(len(clippedPaddedData), len(dayObsData)) | ||
| self.assertGreater(len(clippedPaddedData), len(clippedData)) | ||
|
|
There was a problem hiding this comment.
Either instead of or in addition to these assertGreater/assertLess checks, I would really like to see a check that the length of the padded data was the correct amount longer than the unpadded data.
There was a problem hiding this comment.
Again, I had the same thought. It's actually quite easy to check in this instance, with hard-coded test data, but it's hard in the general case, because a) it's not going be exact, due to the quantized nature of the data, and b) it'll depend on whether or not the input data actually extends out far enough (hence the warning logs for when it doesn't).
There was a problem hiding this comment.
I'll take a swing at that in the morning though, thanks.
There was a problem hiding this comment.
OK, pushed a fix for this, it's in Jenkins now.
mfisherlevine
force-pushed
the
tickets/DM-41807
branch
from
d8155ce
to
5d2c491
Compare
mfisherlevine
force-pushed
the
tickets/DM-41807
branch
from
5d2c491
to
83d85c7
Compare
No description provided.