DM-41885: Make TMAEvents hash so they work with sets #72
Conversation
mfisherlevine
force-pushed
the
tickets/DM-41885
branch
from
e7c7152
to
3179904
Compare
| def __hash__(self): | ||
| # deliberately don't hash the blockInfos here, as they are not | ||
| # a core part of the event itself, and are listy and cause problems | ||
| return hash((self.dayObs, |
There was a problem hiding this comment.
There can only be one source of these events, correct?
There was a problem hiding this comment.
I guess I'm not entirely sure what this means. This is a derived product, made from EFD data, and so for a fixed piece of EFD data and a given version of the generating code, events will be identical, but if EFD data were to change, or the generating code were to be updated, then the derived events could differ. I'm not sure I'm really answering the question, but I'm also not quite sure I understand it.
There was a problem hiding this comment.
Any given person can recalculate these events though, so in that sense there are unlimited sources, but then I can't see how they'd need to set those together, so I doubt that's what you're asking?
There was a problem hiding this comment.
Sorry not to follow better - if you'd prefer to chat about this, just let me know on Slack and we can talk.
There was a problem hiding this comment.
As discussed OOB, this was deemed to be fine because all this is derived from a single source of truth.
No description provided.