Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-41232: Add ICS hardpoint analysis and plotting code #78

Merged
merged 23 commits into from Feb 15, 2024
Merged

DM-41232: Add ICS hardpoint analysis and plotting code #78

merged 23 commits into from Feb 15, 2024

Conversation

mfisherlevine
Copy link
Contributor

No description provided.

b1quint and others added 19 commits February 13, 2024 14:48
@b1quint @mfisherlevine
Move ICS code from summit_testing_analysis
b79ee68
@mfisherlevine
Fix flake8 issues, add docs
64c89ee
@mfisherlevine
Remove space between shared-axis plots, remove show()
0cc3d21
@b1quint @mfisherlevine
Add type_utils.py to support type hint
0b68acf
@b1quint @mfisherlevine
Update plot_hp_measured_data to receive a Figure as argument
831937e
@mfisherlevine
Fix linting issues from Bruno
6c4cfa9
@mfisherlevine
Remove plt.show() and remove whitespace in plots
ba6f17b
@mfisherlevine
Remove fig.tight_layout() call
2638c1f
@mfisherlevine
Add commands to hardpoint plots
94488e7
@b1quint @mfisherlevine
Update ICS plot with limits and new ax for labels
cd767d0
@b1quint @mfisherlevine
Remove from m1m3 ics plots legends
dc6b7b1
@mfisherlevine
Fix linting errors
915a96d
@b1quint @mfisherlevine
M1M3 ICS: Allow empty torqueless regions
7dd75cc
@mfisherlevine
Remove starting shebang, fix __all__
32dd0af 
Add copyright statement
@mfisherlevine
Add note to TMAEventMaker about how to use in tests
bc0002e
@mfisherlevine
Add tests and (re)move test code from __main__ block
0d6ec11
@mfisherlevine
Rename seq_number to seq_num and improve log message
ab7409c
@mfisherlevine
Change evaluate_m1m3_ics_single_slew to take the event itself
ceef949 
Update docstrings and log messages
@mfisherlevine
Fix import weirdness
b7f00af
@mfisherlevine mfisherlevine marked this pull request as ready for review February 13, 2024 22:49
@mfisherlevine mfisherlevine force-pushed the tickets/DM-41232 branch 2 times, most recently from 74fca58 to 7bb4630 Compare February 15, 2024 01:28
@mfisherlevine mfisherlevine merged commit 9ae1cdd into main Feb 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mfisherlevine @b1quint