DM-42719: Handle nan rotation angles in plotting #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taranu
reviewed
Jan 30, 2024
| 'E', | ||
| color='green', fontsize=fontsize, weight='bold') | ||
|
|
||
| if not np.isnan(rotpa): # need a rotation angle for the compass |
There was a problem hiding this comment.
Incredibly, I have a comment on a two-line PR... does it make sense for this and the check below to be if np.isinfinite(rotpa) instead? I suppose you don't need to check if it's between 0 and 2pi.
There was a problem hiding this comment.
Errr, yeah, I guess. Honestly, I'd just never contemplated that they could be +/- inf, but I guess it doesn't hurt to use isfinite instead.
mfisherlevine
force-pushed
the
tickets/DM-42719
branch
from
5100a5c
to
e64859d
Compare
mfisherlevine
force-pushed
the
tickets/DM-42719
branch
from
e64859d
to
73b3a12
Compare
mfisherlevine
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.