DM-42054: Remove limit of 1 for getCommandsDuringEvent #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfisherlevine
force-pushed
the
tickets/DM-42054
branch
from
c693b56
to
5e1972e
Compare
fritzm
reviewed
Mar 1, 2024
| if timeFormat not in ['pandas', 'astropy', 'python']: | ||
| raise ValueError(f"format must be one of 'pandas', 'astropy' or 'python', not {timeFormat=}") | ||
|
|
||
| commands = list(ensure_iterable(commands)) |
There was a problem hiding this comment.
Why "listify" here? Can't the iterable be directly used in the for loop below?
There was a problem hiding this comment.
I hate that too, but ensure_iterable will just return an exhaustible generator if it got one of those, and I hate accidentally consuming things when looping over them to find they're now gone, so just tend to do that for safety when I know the list is small, mainly just out of habit. It's not necessary here, but it's also probably less harmful than not doing it, on balance.
fritzm
reviewed
Mar 1, 2024
| log = logging.getLogger(__name__) | ||
|
|
||
| commands = ensure_iterable(commands) | ||
| commands = list(ensure_iterable(commands)) |
fritzm
approved these changes
Mar 1, 2024
|
Thanks. Should be fine though, this can't affect anything in Tiago-town (expect making it easier for him to use this code to debug things 🙂) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.