DM-43137: Use dayObs as bind parameter instead of day_obs in queries

.github/workflows/rebase_checker.yaml

@@ -0,0 +1,7 @@
+name: Check that 'main' is not merged into the development branch
+
+on: pull_request
+
+jobs:
+  call-workflow:
+    uses: lsst/rubin_workflows/.github/workflows/rebase_checker.yaml@main

.gitignore

@@ -1,3 +1,5 @@
+.coverage*
+_build.*
 .sconsign.dblite
 config.log
 .sconf_temp

python/lsst/summit/utils/astrometry/anet.py

@@ -105,7 +105,7 @@ def rmsErrorArsec(self):
         return self.rmsErrorPixels * self.plateScale
 
 
-class CommandLineSolver():
+class CommandLineSolver:
     """An interface for the solve-field command line tool from astrometry.net.
 
     Parameters
@@ -306,7 +306,7 @@ def run(self, exp, sourceCat, isWideField, *,
         return None
 
 
-class OnlineSolver():
+class OnlineSolver:
     """A class to solve an image using the Astrometry.net online service.
     """
 

python/lsst/summit/utils/bestEffort.py

@@ -34,7 +34,7 @@
 CURRENT_RUN = "LATISS/runs/quickLook/1"
 
 
-class BestEffortIsr():
+class BestEffortIsr:
     """Class for getting an assembled image with the maximum amount of isr.
 
     BestEffortIsr.getExposure(dataId) returns an assembled image with as much

python/lsst/summit/utils/butlerUtils.py

@@ -266,13 +266,13 @@ def getSeqNumsForDayObs(butler, day_obs, extraWhere=''):
         order.
     """
     day_obs = sanitizeDayObs(day_obs)
-    where = "exposure.day_obs=day_obs"
+    where = "exposure.day_obs=dayObs"
     if extraWhere:
         extraWhere = extraWhere.replace('"', '\'')
         where += f" and {extraWhere}"
     records = butler.registry.queryDimensionRecords("exposure",
                                                     where=where,
-                                                    bind={'day_obs': day_obs},
+                                                    bind={'dayObs': day_obs},
                                                     datasets='raw')
     return sorted([r.seq_num for r in records])
 
@@ -507,10 +507,10 @@ def getExpRecordFromDataId(butler, dataId):
         seqNum = getSeqNum(dataId)
         if not (dayObs and seqNum):
             raise RuntimeError(f'Failed to find either expId or day_obs and seq_num in dataId {dataId}')
-        where = "exposure.day_obs=day_obs AND exposure.seq_num=seq_num"
+        where = "exposure.day_obs=dayObs AND exposure.seq_num=seq_num"
         expRecords = butler.registry.queryDimensionRecords("exposure",
                                                            where=where,
-                                                           bind={'day_obs': dayObs, 'seq_num': seqNum},
+                                                           bind={'dayObs': dayObs, 'seq_num': seqNum},
                                                            datasets='raw')
 
     expRecords = set(expRecords)
@@ -748,13 +748,13 @@ def isOnSky(expRecord):
         days = [d for d in days if d <= endDate]
     days = sorted(set(days))
 
-    where = "exposure.day_obs=day_obs"
+    where = "exposure.day_obs=dayObs"
     for day in days:
         # queryDataIds would be better here, but it's then hard/impossible
         # to do the filtering for which is on sky, so just take the dataIds
         records = butler.registry.queryDimensionRecords("exposure",
                                                         where=where,
-                                                        bind={'day_obs': day},
+                                                        bind={'dayObs': day},
                                                         datasets='raw')
         recordSets.append(sortRecordsByDayObsThenSeqNum(records))
 

python/lsst/summit/utils/imageExaminer.py

@@ -46,7 +46,7 @@ def gauss(x, a, x0, sigma):
     return a*np.exp(-(x-x0)**2/(2*sigma**2))
 
 
-class ImageExaminer():
+class ImageExaminer:
     """Class for the reproducing some of the functionality of imexam.
 
     For an input image create a summary plot showing:

python/lsst/summit/utils/nightReport.py

@@ -60,7 +60,7 @@ class ColorAndMarker:
     marker: str = '*'
 
 
-class NightReport():
+class NightReport:
     _version = 1
 
     def __init__(self, butler, dayObs, loadFromFile=None):
@@ -149,8 +149,8 @@ def getExpRecordDictForDayObs(self, dayObs):
         Runs in ~0.05s for 1000 records.
         """
         expRecords = self.butler.registry.queryDimensionRecords("exposure",
-                                                                where="exposure.day_obs=day_obs",
-                                                                bind={'day_obs': dayObs},
+                                                                where="exposure.day_obs=dayObs",
+                                                                bind={'dayObs': dayObs},
                                                                 datasets='raw')
         expRecords = list(expRecords)
         records = {e.seq_num: e.toDict() for e in expRecords}  # not guaranteed to be in order

python/lsst/summit/utils/spectrumExaminer.py

@@ -37,7 +37,7 @@
 from lsst.summit.utils.utils import getImageStats
 
 
-class SpectrumExaminer():
+class SpectrumExaminer:
     """Task for the QUICK spectral extraction of single-star dispersed images.
 
     For a full description of how this tasks works, see the run() method.