DM-43141: Fix StarTracker analysis to work with new headers #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
approved these changes
Mar 5, 2024
| @@ -263,11 +263,13 @@ def runCharactierizeImage(exp, snr, minPix): | |||
| charConfig.doMeasurePsf = False | |||
| charConfig.doApCorr = False | |||
| charConfig.doDeblend = False | |||
| charConfig.doMaskStreaks = False | |||
There was a problem hiding this comment.
Probably not an issue for the star trackers, but note that some downstream code may fail if the STREAK mask is not present (I consider that a bug in our code). I believe you are already aware of this, but also note that streak masking is going to move to detectAndMeasure on difference images soon, and will not be part of the refactored calibrateImageTask.
There was a problem hiding this comment.
That's great, thanks 👍
mfisherlevine
force-pushed
the
tickets/DM-43141
branch
from
ff3eaf5
to
5a7c47e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes bitrot from config changes upstream and updates to astropy.