DM-43169: Create utility function to check for timebase errors #87
Conversation
| ) | ||
| return False | ||
|
|
||
| return np.max(np.diff(cRIOtimestamps.values)) > maxDiff |
There was a problem hiding this comment.
Should this be checking for np.max(np.abs(... instead?
There was a problem hiding this comment.
You know, kinda, but honestly, if time is running backwards then I think bets are so far off I'm happy to let it slide or explode in some other way.
There was a problem hiding this comment.
OK, then I suggest you make this raise if the diff is negative.
| client : `lsst_efd_client.efd_helper.EfdClient` | ||
| The EFD client to use. | ||
| maxDiff : `float`, optional | ||
| The maximum difference in cRIO timestamps to consider as a timebase |
There was a problem hiding this comment.
Units are seconds? Also, is this the absolute value of the difference?
There was a problem hiding this comment.
Yup, will add comment on being seconds, though it's hard-coded in the cRIO, so it's somewhat irrelevant and would need re-crafting for other topics depending on how they're packed.
| # You should have received a copy of the GNU General Public License | ||
| # along with this program. If not, see <https://www.gnu.org/licenses/>. | ||
|
|
||
| from .mount import * |
There was a problem hiding this comment.
Maybe just import hasTimebaseErrors instead of *
mfisherlevine
force-pushed
the
tickets/DM-43169
branch
from
a8c2fb6
to
32c75aa
Compare
No description provided.